Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning by replacing charlist with string #772

Merged

Conversation

zhihuizhang17
Copy link
Contributor

This PR fixes warning: single-quoted strings represent charlists. Use ~c"" if you indeed want a charlist or use "" instead

Copy link

linux-foundation-easycla bot commented Sep 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: zhihuizhang17 / name: zhihuz (f80cd08)

@zhihuizhang17 zhihuizhang17 marked this pull request as ready for review September 14, 2024 07:49
@zhihuizhang17 zhihuizhang17 requested a review from a team September 14, 2024 07:49
@zhihuizhang17 zhihuizhang17 force-pushed the zhihuizhang/fix-warning branch from 3e7ff20 to f80cd08 Compare September 14, 2024 07:54
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (3aab0a7) to head (f80cd08).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files          64       64           
  Lines        1940     1940           
=======================================
  Hits         1420     1420           
  Misses        520      520           
Flag Coverage Δ
api 69.90% <ø> (ø)
elixir 17.32% <ø> (ø)
erlang 74.51% <ø> (ø)
exporter 73.06% <ø> (ø)
sdk 77.30% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryannaegele bryannaegele merged commit 61ecf5d into open-telemetry:main Sep 16, 2024
15 checks passed
@zhihuizhang17
Copy link
Contributor Author

Hi @bryannaegele , could you help make an new release in hex.pm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants