-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and delete conventions following spec #684
Update and delete conventions following spec #684
Conversation
Create following the BREAKINGs of OTEL spec https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md
Cool. Was this done with the generation script? The app version would need to change too. But I think this upgrade in semconv is still blocked for us by http stuff. @bryannaegele ? I should probably try to knock that out before I start working again so we can upgrade semconv... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
==========================================
+ Coverage 73.13% 74.35% +1.21%
==========================================
Files 64 56 -8
Lines 1943 1852 -91
==========================================
- Hits 1421 1377 -44
+ Misses 522 475 -47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No, I applied the changes manually verifying the spec. Is that this script? |
We still have to implement the env var checking. I don't know how we're going to deal with the new plus old. I threw out running the script, diffing, and adding deprecated stuff but that had a host of problems. I know this is still an issue the wg knows of in general with no progress as yet. I think there are several other sigs frustrated by it. |
Ugh, we have got to do something about being stuck on old semconv. Next time we meet, @bryannaegele , lets be sure to write up a detailed issue and I'll do my best to knock it out. I keep losing context on the issue and feeling like I have to start over figuring out just what to do. |
@joaothallis this is being addressed in #733 |
Create following the BREAKINGs of OTEL spec
https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md