Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(otel_otlp_metrics): convert histogram timestamps and fix 'unix_nano' field names #648

Conversation

SergeTupchiy
Copy link
Contributor

Follow up fix my previous PR: #644

Accidentally removed _unix_nano suffixes in proto field names, which was not needed...

@SergeTupchiy SergeTupchiy requested a review from a team November 10, 2023 19:54
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41c793c) 72.94% compared to head (02786fa) 72.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #648   +/-   ##
=======================================
  Coverage   72.94%   72.94%           
=======================================
  Files          61       61           
  Lines        1918     1918           
=======================================
  Hits         1399     1399           
  Misses        519      519           
Flag Coverage Δ
api 69.64% <ø> (ø)
elixir 17.47% <ø> (ø)
erlang 74.26% <ø> (ø)
exporter 66.66% <ø> (ø)
sdk 78.69% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsloughter tsloughter merged commit a79a39f into open-telemetry:main Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants