Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky test #630

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Fix flaky test #630

merged 2 commits into from
Oct 2, 2023

Conversation

albertored
Copy link
Contributor

Fix #616

The problem is that the 2 test modules were running concurrently and they are both modifying the :opentelemetry application environment. Sometimes the metric test sets the exporter to none and next span test fails.

@albertored albertored requested a review from a team October 2, 2023 10:29
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

tsloughter
tsloughter approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@tsloughter tsloughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Thanks!

@tsloughter tsloughter merged commit 46e690c into open-telemetry:main Oct 2, 2023
20 checks passed
@albertored albertored deleted the flaky-test branch October 2, 2023 12:20
@albertored albertored mentioned this pull request Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsloughter tsloughter tsloughter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flappy Elixir test
2 participants
@albertored @tsloughter