move attribute processing to otel-attribute module #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
ferd
approved these changes
Aug 31, 2023
| is_boolean(Value) orelse | ||
| is_number(Value) orelse | ||
| is_binary(Value) orelse | ||
| is_list(Value)). |
There was a problem hiding this comment.
you might want to put both of these guard clauses in a wrapping (...) so they can be composed with others without messing with evaluation rules when andalso and orelse are called with them.
tsloughter
force-pushed
the
attribute-processing
branch
from
a4d24f0 to
6957343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just cleans up some stuff that got put in otel_span because otel_attributes was in the SDK.
I checked that no lib in -contrib is calling the otel_span functions