-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Histogram buckets should be 1 more than boundaries #614
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 72.49% 72.49%
=======================================
Files 61 61
Lines 1923 1923
=======================================
Hits 1394 1394
Misses 529 529
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Also, as per the spec it seems that our default boundaries are missing some values (2500, 5000, 7500, 10000), I can add them in this PR |
Thanks! And yea, the spec changed since this was written. |
be9194e
to
5950dd4
Compare
@tsloughter default boundaries aligned with the specification, it should be ready to be merged |
Needs a changelog update. |
Adpat default boundaries to last version of the specs
5950dd4
to
57b6748
Compare
@tsloughter done |
Histogram buckets should be 1 more than histogram boundaries. At the moment values greater than the last boundary (let's call it
T(n)
) are accumulated in the boundary(T(n-1), T(n)]
instead of(T(n), +infinity)