Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User-Agent header to exporter requests #605

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

albertored
Copy link
Contributor

Fixes #473

@albertored albertored requested a review from a team August 20, 2023 14:12
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a79a39f) 72.94% compared to head (0bf88c2) 73.02%.

Files Patch % Lines
...ntelemetry_exporter/src/opentelemetry_exporter.erl 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   72.94%   73.02%   +0.08%     
==========================================
  Files          61       61              
  Lines        1918     1924       +6     
==========================================
+ Hits         1399     1405       +6     
  Misses        519      519              
Flag Coverage Δ
api 69.64% <ø> (ø)
elixir 17.47% <ø> (ø)
erlang 74.35% <75.00%> (+0.08%) ⬆️
exporter 67.47% <75.00%> (+0.81%) ⬆️
sdk 78.69% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertored
Copy link
Contributor Author

@tsloughter moving into draft because I need to verify how to add the user agent also on grpc calls

@albertored
Copy link
Contributor Author

@tsloughter we need to fix grpcbox for this to work correctly, see linked PR

@albertored albertored marked this pull request as ready for review November 20, 2023 08:14
@albertored
Copy link
Contributor Author

@tsloughter with the recent bump of grpcbox this should be ready to be merged

@tsloughter tsloughter merged commit b5764e6 into open-telemetry:main Nov 20, 2023
14 checks passed
@albertored albertored deleted the exporter-user-agent branch November 20, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTLP exporters should emit standard user agent string
2 participants