-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for OTEL_SDK_DISABLED environment variable #574
Conversation
setup_text_map_propagators(Config), | ||
|
||
%% set global span limits record based on configuration | ||
otel_span_limits:set(Config), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reordered this because I was going to put a case Disabled
around the parts that don't need to run if the SDK is disabled but then didn't because its not exactly required since the supervisor simply starts no children and that causes everything to fallback to no-ops.
Undecided.. Maybe I should check if its disabled here too and not do stuff like get_resource
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I went ahead and added the check if sdk is disabled and skip the stuff below.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #574 +/- ##
==========================================
+ Coverage 38.05% 38.11% +0.05%
==========================================
Files 61 61
Lines 3592 3597 +5
==========================================
+ Hits 1367 1371 +4
- Misses 2225 2226 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Resolves #573