Move is_monotonic check to the SDK #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This required changing the aggregate API to be passed the view_aggregation record so it has access to is_monotonic. The API feels a little cleaner anyway.
This has more dialyzer ignores added in order to remove stuff like '$1' and '_' in type specs. I figure this is acceptable because eqwalizer has a more fine grained ignore ability which will let us check these parts of the code better even if the dialyzer warnings are now ignored from those parts of the code.
ferd
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API needs to not log about bad data to instruments, this removes a check on counters being positive measurements.
It does so by changing the SDK's aggregation api to accept a
#view_aggregation{}which containsis_monotonic.I'm not ready to call this api of the SDK done, but a good step for a PR.