Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom text propagator to be configured via application env #408

Merged
merged 1 commit into from
Jun 11, 2022

Conversation

ananthakumaran
Copy link
Contributor

fixes #396

@codecov
Copy link

codecov bot commented Jun 11, 2022

Codecov Report

Merging #408 (a4b4d90) into main (94d385d) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #408      +/-   ##
==========================================
- Coverage   73.27%   73.23%   -0.05%     
==========================================
  Files          53       53              
  Lines        1654     1655       +1     
==========================================
  Hits         1212     1212              
- Misses        442      443       +1     
Flag Coverage Δ
api 68.70% <ø> (ø)
elixir 17.54% <ø> (ø)
erlang 74.65% <0.00%> (-0.05%) ⬇️
exporter 73.59% <ø> (ø)
sdk 78.09% <0.00%> (-0.10%) ⬇️
zipkin 53.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
apps/opentelemetry/src/otel_configuration.erl 80.28% <0.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94d385d...a4b4d90. Read the comment docs.

@tsloughter
Copy link
Member

Sorry, one last thing, can you update the changelog file at the top of the repo to include this as a SDK fix.

@ananthakumaran ananthakumaran changed the title Allow custom propagator to be configured via application env Allow custom text propagator to be configured via application env Jun 11, 2022
@tsloughter tsloughter merged commit ccbe7f1 into open-telemetry:main Jun 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to use custom propagator via config
2 participants