-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace InstrumentationLibrary with InstrumentationScope #405
replace InstrumentationLibrary with InstrumentationScope #405
Conversation
This is mostly ready but need to find where it isn't backwards compatible and fix those spots. I think the only place it isn't is that it would be getting rid of the |
Codecov Report
@@ Coverage Diff @@
## main #405 +/- ##
==========================================
- Coverage 73.23% 73.18% -0.05%
==========================================
Files 53 53
Lines 1655 1656 +1
==========================================
Hits 1212 1212
- Misses 443 444 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hmm, nevermind, it looks like we only have |
2569f17
to
597e0ee
Compare
@@ -86,7 +87,7 @@ | |||
|
|||
-type tracer() :: {module(), term()}. | |||
|
|||
-type instrumentation_library() :: #instrumentation_library{}. | |||
-type instrumentation_scope() :: #instrumentation_scope{}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth maintaining the type alias as well?
-type instrumentation_library() :: #instrumentation_scope{}.
or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt it. If any user actually uses the library record the least of what they have to deal with is the type spec.
597e0ee
to
7dadcc2
Compare
Spec change can be found in PR:
open-telemetry/opentelemetry-specification#2276