Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cowboy SemConv 1.27.0 #359

Merged
merged 18 commits into from
Oct 15, 2024

Conversation

bryannaegele
Copy link
Collaborator

@bryannaegele bryannaegele commented Aug 17, 2024

SemConv 1.26 compatibility.

This also introduces the equivalent of Go's public endpoint functionality to let users decide when a request should be processed as internal or external.

This introduces a large number of breaking changes from the evolution of the spec since 1.17 and 1.20. Given the stability of the library over time to date and the need to version to a breaking number, we'll set this to 1.0.0 to force users to manually bump the version.

Addresses #183 for cowboy

Resolves #361

Relies on open-telemetry/opentelemetry-erlang#733 and #358

@bryannaegele bryannaegele marked this pull request as draft August 17, 2024 20:55
@bryannaegele bryannaegele added the major Major version label Aug 17, 2024
@bryannaegele bryannaegele marked this pull request as ready for review September 24, 2024 22:39
@bryannaegele bryannaegele changed the title Cowboy SemConv 1.26.0 Cowboy SemConv 1.27.0 Sep 24, 2024
Copy link
Contributor

@GregMefford GregMefford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small things I noticed.

Copy link
Contributor

@GregMefford GregMefford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge.

bryannaegele and others added 18 commits October 15, 2024 16:14

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Greg Mefford <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Greg Mefford <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Greg Mefford <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Greg Mefford <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Co-authored-by: Greg Mefford <[email protected]>

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@bryannaegele bryannaegele merged commit 0b242c8 into open-telemetry:main Oct 15, 2024
27 checks passed
@bryannaegele bryannaegele deleted the cowboy-1.25-semconv branch October 15, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cowboy - SemConv 1.26
2 participants