Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[phoenix instrumenter] Allow to configure which headers should be used as span attrs #185

Closed
wants to merge 2 commits into from
Closed

[phoenix instrumenter] Allow to configure which headers should be used as span attrs #185

wants to merge 2 commits into from

Conversation

albertored
Copy link
Contributor

See #183

@tsloughter
Copy link
Member

Thanks! Pls update the CHANGELOG tho

@albertored albertored marked this pull request as draft July 15, 2023 13:01
@albertored
Copy link
Contributor Author

Marked as draft since it need #186 to be merged before proceeding

@albertored
Copy link
Contributor Author

Closing in favour of #184

@albertored albertored closed this Jul 24, 2023
@albertored albertored deleted the phoenix-include-headers-in-attrs branch July 24, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryannaegele bryannaegele Awaiting requested review from bryannaegele bryannaegele is a code owner

@tsloughter tsloughter Awaiting requested review from tsloughter tsloughter is a code owner

Assignees
No one assigned
Labels
elixir instrumentation opentelemetry_phoenix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertored @tsloughter