Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record an exception as an error only when Plug.Exception.status/1 returns 500..599. #165

Merged
merged 2 commits into from
Jul 6, 2023
Merged

Record an exception as an error only when Plug.Exception.status/1 returns 500..599. #165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e455594
Record an exception as an error only when Plug.Exception.status/1
derekkraan Apr 19, 2023
2ef75f7
Merge branch 'main' into main
tsloughter Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion instrumentation/opentelemetry_phoenix/lib/opentelemetry_phoenix.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ defmodule OpentelemetryPhoenix do

# record exception and mark the span as errored
Tracer.record_exception(exception, stacktrace, attrs)
Tracer.set_status(OpenTelemetry.status(:error, ""))

# do not close the span as endpoint stop will still be called with
# more info, including the status code, which is nil at this stage
Expand Down