Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine reporter caches #215

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Refine reporter caches #215

merged 5 commits into from
Oct 30, 2024

Conversation

rockdaboot
Copy link
Contributor

  • separate sizes of reporter caches and size of tracehandler cache
  • reduce memory consumption by using smaller but still sufficient cache sizes
  • add a lifetime for cache items
  • regularly purge expired cache items to avoid memory leaks

@rockdaboot rockdaboot self-assigned this Oct 29, 2024
@rockdaboot rockdaboot requested review from a team as code owners October 29, 2024 11:27
@dmathieu dmathieu mentioned this pull request Oct 29, 2024
Merged
@rockdaboot rockdaboot requested a review from florianl October 29, 2024 14:52
fabled
fabled approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@fabled fabled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (added one stylistic nit). Thank you!

@christos68k christos68k merged commit 1618b30 into open-telemetry:main Oct 30, 2024
23 checks passed
@Gandem Gandem mentioned this pull request Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@fabled fabled fabled approved these changes

@florianl florianl florianl approved these changes

@christos68k christos68k christos68k approved these changes

Assignees

@rockdaboot rockdaboot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rockdaboot @dmathieu @fabled @florianl @christos68k