Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup internal agent controller #203

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Conversation

dmathieu
Copy link
Member

This extracts the running of the agent controller into an internal struct rather than being on main.go, so the collector receiver can reuse this code.

@dmathieu
Copy link
Member Author

I have removed controller tests, as running a controller in a test environment isn't really doable right now (we need sudo for rlimit for example).
I'll create an issue to track allowing the creation of mocks or similar ways to permit testing this package.

@dmathieu dmathieu marked this pull request as ready for review October 24, 2024 12:18
@dmathieu dmathieu requested review from a team as code owners October 24, 2024 12:18
internal/controller/controller.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
dmathieu and others added 3 commits October 24, 2024 14:46
Co-authored-by: Christos Kalkanis <[email protected]>
@rockdaboot rockdaboot merged commit 5af7c72 into open-telemetry:main Oct 24, 2024
23 checks passed
florianl pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants