Add a Jaeger Activity Exporter #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
requested review from
bruno-garcia,
cijothomas,
discostu105,
lmolkova,
MikeGoldsmith and
SergeyKanzhelev
as code owners
pjanotti
commented
May 21, 2020
| @@ -89,7 +89,7 @@ public async Task JaegerExporter_Batching() | |||
| { | |||
| for (int c = 0; c < this.NumberOfSpans; c++) | |||
| { | |||
| await jaegerUdpBatcher.AppendAsync(this.testSpan, CancellationToken.None).ConfigureAwait(false); | |||
| await jaegerUdpBatcher.AppendAsync(this.testSpan.ToJaegerSpan(), CancellationToken.None).ConfigureAwait(false); | |||
There was a problem hiding this comment.
Prior to this PR ToJaegerSpan() was called inside AppendAsync so the amount of work in the benchmark it is still the same.
pjanotti
commented
May 21, 2020
| { | ||
| internal static class JaegerActivityExtensions | ||
| { | ||
| private static readonly Dictionary<string, int> PeerServiceKeyResolutionDictionary = new Dictionary<string, int>(StringComparer.OrdinalIgnoreCase) |
There was a problem hiding this comment.
For now, this is duplicated with the extensions for SDK span. Likely should move to a common location.
|
LGTM |
cijothomas
reviewed
May 22, 2020
cijothomas
reviewed
May 22, 2020
cijothomas
reviewed
May 22, 2020
cijothomas
approved these changes
May 22, 2020
|
Leaving unmerged for at least a day to give everyone a chance to review. |
Illia-M
added a commit
to gr8-toolkit/opentelemetry-dotnet
that referenced
this pull request
May 25, 2020
Add a Jaeger Activity Exporter (open-telemetry#693)
3 tasks
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a Jaeger Activity Exporter. The code uses the same patterns already in the Jaeger Exporter and adds a new exporter capable of transforming
Activityinstances into Jaeger spans.Checklist