Asp.Net Core Requests Instrumentation - change to use new Activity API

samples/Exporters/Web/OpenTelemetry.Exporter.Web.csproj

@@ -12,6 +12,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <ProjectReference Include="..\..\..\src\OpenTelemetry.Exporter.Console\OpenTelemetry.Exporter.Console.csproj" />
     <ProjectReference Include="..\..\..\src\OpenTelemetry.Instrumentation.AspNetCore\OpenTelemetry.Instrumentation.AspNetCore.csproj" />
     <ProjectReference Include="..\..\..\src\OpenTelemetry.Instrumentation.Dependencies\OpenTelemetry.Instrumentation.Dependencies.csproj" />
     <ProjectReference Include="..\..\..\src\OpenTelemetry.Exporter.Zipkin\OpenTelemetry.Exporter.Zipkin.csproj" />

samples/Exporters/Web/Startup.cs

@@ -7,6 +7,7 @@
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Hosting;
 using Microsoft.OpenApi.Models;
+using OpenTelemetry.Exporter.Console;
 using OpenTelemetry.Trace.Configuration;
 
 namespace API
@@ -36,6 +37,11 @@ public void ConfigureServices(IServiceCollection services)
                 }
             });
 
+
+            OpenTelemetrySdk.EnableOpenTelemetry(
+                (builder) => builder.AddActivitySource("Microsoft.AspNetCore")
+                .UseConsoleActivityExporter(opt => opt.DisplayAsJson = opt.DisplayAsJson));
+
             services.AddOpenTelemetry((sp, builder) =>
             {
                 builder

src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs

@@ -36,6 +36,9 @@ internal class HttpInListener : ListenerHandler
         private readonly bool hostingSupportsW3C = false;
         private readonly AspNetCoreInstrumentationOptions options;
 
+        // Create an ActivitySource here to re-create Activity.
+        private ActivitySource activitySource = new ActivitySource("Microsoft.AspNetCore");
+
         public HttpInListener(string name, Tracer tracer, AspNetCoreInstrumentationOptions options)
             : base(name, tracer)
         {
@@ -60,11 +63,21 @@ public override void OnStartActivity(Activity activity, object payload)
                 return;
             }
 
+            // Create a brand new activity using ActivitySource
+            // and populate its tags correctly.
+            // This is double allocation of Activity! and probably bad for performance.
+            var newActivity = this.activitySource.StartActivity("HttpRequestIn", ActivityKind.Server);
+
             var request = context.Request;
 
             // see the spec https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/data-semantic-conventions.md
             var path = (request.PathBase.HasValue || request.Path.HasValue) ? (request.PathBase + request.Path).ToString() : "/";
 
+            if (newActivity != null)
+            {
+                newActivity.DisplayName = path;
+            }
+
             TelemetrySpan span;
             if (this.hostingSupportsW3C && this.options.TextFormat is TraceContextFormat)
             {
@@ -90,6 +103,28 @@ public override void OnStartActivity(Activity activity, object payload)
                 span.PutHttpUserAgentAttribute(userAgent);
                 span.PutHttpRawUrlAttribute(GetUri(request));
             }
+
+            if (newActivity != null)
+            {
+                if (newActivity.IsAllDataRequested)
+                {
+                    if (request.Host.Port == 80 || request.Host.Port == 443)
+                    {
+                        newActivity.AddTag("http.host", request.Host.Host);
+                    }
+                    else
+                    {
+                        newActivity.AddTag("http.host", request.Host.Host + ":" + request.Host.Port);
+                    }
+
+                    newActivity.AddTag("http.method", request.Method);
+                    newActivity.AddTag("http.path", path);
+
+                    var userAgent = request.Headers["User-Agent"].FirstOrDefault();
+                    newActivity.AddTag("http.user_agent", userAgent);
+                    newActivity.AddTag("http.url", GetUri(request));
+                }
+            }
         }
 
         public override void OnStopActivity(Activity activity, object payload)
@@ -114,8 +149,15 @@ public override void OnStopActivity(Activity activity, object payload)
                 var response = context.Response;
 
                 span.PutHttpStatusCode(response.StatusCode, response.HttpContext.Features.Get<IHttpResponseFeature>().ReasonPhrase);
+
+                // activity here will be the activity which we created using ActivitySource in the Start callback.
+                if (activity.IsAllDataRequested)
+                {
+                    activity.AddTag("http.status_code", response.StatusCode.ToString());
+                }
             }
 
+            activity.Stop();
             span.End();
         }