-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] Mark ActivityExtensions.RecordException obsolete #5841
Merged
CodeBlanch
merged 16 commits into
open-telemetry:main
from
ysolomchenko:mark-ActivityExtensions.RecordException-obsolete
Sep 24, 2024
Merged
[api] Mark ActivityExtensions.RecordException obsolete #5841
CodeBlanch
merged 16 commits into
open-telemetry:main
from
ysolomchenko:mark-ActivityExtensions.RecordException-obsolete
Sep 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry.Api
Issues related to OpenTelemetry.Api NuGet package
label
Sep 18, 2024
CodeBlanch
reviewed
Sep 18, 2024
cijothomas
reviewed
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5841 +/- ##
==========================================
+ Coverage 83.38% 86.27% +2.89%
==========================================
Files 297 257 -40
Lines 12531 11185 -1346
==========================================
- Hits 10449 9650 -799
+ Misses 2082 1535 -547
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…tps://github.com/ysolomchenko/opentelemetry-dotnet into mark-ActivityExtensions.RecordException-obsolete
This reverts commit ed9927f.
github-actions
bot
added
infra
Infra work - CI/CD, code coverage, linters
dependencies
Pull requests that update a dependency file
labels
Sep 24, 2024
github-actions
bot
removed
infra
Infra work - CI/CD, code coverage, linters
dependencies
Pull requests that update a dependency file
labels
Sep 24, 2024
cijothomas
approved these changes
Sep 24, 2024
reyang
approved these changes
Sep 24, 2024
rajkumar-rangaraj
approved these changes
Sep 24, 2024
Kielek
approved these changes
Sep 24, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5665
Changes
Mark ActivityExtensions.RecordException obsolete
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes