Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Mark ActivityExtensions.RecordException obsolete #5841

Conversation

ysolomchenko
Copy link
Contributor

Fixes #5665

Changes

Mark ActivityExtensions.RecordException obsolete

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package label Sep 18, 2024
@ysolomchenko ysolomchenko marked this pull request as ready for review September 18, 2024 09:55
@ysolomchenko ysolomchenko requested a review from a team September 18, 2024 09:55
@CodeBlanch CodeBlanch requested a review from a team as a code owner September 20, 2024 19:52
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (6250307) to head (b148505).
Report is 326 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5841      +/-   ##
==========================================
+ Coverage   83.38%   86.27%   +2.89%     
==========================================
  Files         297      257      -40     
  Lines       12531    11185    -1346     
==========================================
- Hits        10449     9650     -799     
+ Misses       2082     1535     -547     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.20% <100.00%> (?)
unittests-Project-Stable 86.27% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 86.36% <100.00%> (-9.10%) ⬇️

... and 226 files with indirect coverage changes

@github-actions github-actions bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file labels Sep 24, 2024
@github-actions github-actions bot removed infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file labels Sep 24, 2024
@CodeBlanch CodeBlanch merged commit 12a8ab0 into open-telemetry:main Sep 24, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:OpenTelemetry.Api Issues related to OpenTelemetry.Api NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark ActivityExtensions.RecordException obsolete
6 participants