Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk-metrics] Refactor duplicated update completion code into a helper in MetricPoint #5398

Merged

Conversation

CodeBlanch
Copy link
Member

Changes

  • Fix a few violations of DRY by introducing a helper method for update completion code 😄

@CodeBlanch CodeBlanch added pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package metrics Metrics signal related labels Feb 28, 2024
@CodeBlanch CodeBlanch requested a review from a team February 28, 2024 19:03
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.54%. Comparing base (6250307) to head (1277a09).
Report is 104 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5398      +/-   ##
==========================================
+ Coverage   83.38%   84.54%   +1.16%     
==========================================
  Files         297      284      -13     
  Lines       12531    12096     -435     
==========================================
- Hits        10449    10227     -222     
+ Misses       2082     1869     -213     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 84.52% <100.00%> (?)
unittests-Solution-Stable 84.29% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry/Metrics/MetricPoint.cs 92.81% <100.00%> (+24.34%) ⬆️

... and 54 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 7ce0c55 into open-telemetry:main Feb 28, 2024
37 checks passed
@CodeBlanch CodeBlanch deleted the sdk-metricpoint-completeupdate branch February 28, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics signal related pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants