Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve comment for SamplingDecision.Drop #5370

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Improve comment for SamplingDecision.Drop #5370

merged 1 commit into from
Feb 20, 2024

Conversation

joegoldman2
Copy link
Contributor

No description provided.

@joegoldman2 joegoldman2 requested a review from a team February 18, 2024 07:53
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6250307) 83.38% compared to head (bcee048) 83.10%.
Report is 86 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5370      +/-   ##
==========================================
- Coverage   83.38%   83.10%   -0.29%     
==========================================
  Files         297      276      -21     
  Lines       12531    12001     -530     
==========================================
- Hits        10449     9973     -476     
+ Misses       2082     2028      -54     
Flag Coverage Δ
unittests ?
unittests-Solution-Experimental 83.08% <ø> (?)
unittests-Solution-Stable 83.08% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 46 files with indirect coverage changes

@utpilla utpilla merged commit d27e9ba into open-telemetry:main Feb 20, 2024
37 checks passed
@joegoldman2 joegoldman2 deleted the patch-1 branch February 20, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants