-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Instrumentation.SqlClient] Stop emitting db.statement_type attribute #5301
[Instrumentation.SqlClient] Stop emitting db.statement_type attribute #5301
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5301 +/- ##
==========================================
- Coverage 83.38% 83.06% -0.32%
==========================================
Files 297 272 -25
Lines 12531 11971 -560
==========================================
- Hits 10449 9944 -505
+ Misses 2082 2027 -55
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #
Design discussion issue #
Changes
[Instrumentation.SqlClient] Stop emitting
db.statement_type
attribute.It was introduced in https://github.com/open-telemetry/opentelemetry-dotnet/pull/761/files#r450626620. It is not part of semantic convention. I didn't find any other occurrence for this except open-telemetry/opentelemetry-dotnet-contrib#1559
As a separate work, we should consider adding
db.operation
/sanitizingdb.statement
.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)N/A