-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Add DelegatingProcessor #5282
[sdk] Add DelegatingProcessor #5282
Conversation
My first thought, are there any one-off Processors in the Test projects that this could replace? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5282 +/- ##
==========================================
- Coverage 83.38% 82.91% -0.48%
==========================================
Files 297 273 -24
Lines 12531 11993 -538
==========================================
- Hits 10449 9944 -505
+ Misses 2082 2049 -33
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Relates to #5255
Changes
DelegatingProcessor<T>
class to SDK.Details & reasoning
We don't stop users from making more derived versions of our built-in processors or wrapping them in other processors. An example of this is #5250.
Users who wrap one of the built-in processors may run into two things:
Resource
resolution.LogRecord
pool when batching is in play ([logs] Fix pooling issues when wrapping batch export processor #5255).Because we can't prevent this, what we should do (IMHO) is give a way to do it safely:
DelegatingProcessor
Here is how a user could write the
FilterProcessor
(from #5250) to be safe usingDelegatingProcessor
:Public API changes
OpenTelemetry.dll:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes