-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Include license files in packages #5192
[repo] Include license files in packages #5192
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5192 +/- ##
==========================================
+ Coverage 83.43% 83.49% +0.05%
==========================================
Files 297 297
Lines 12396 12395 -1
==========================================
+ Hits 10343 10349 +6
+ Misses 2053 2046 -7
Flags with carried forward coverage won't be shown. Click here to find out more. |
<PackageOutputPath Condition="$(Build_ArtifactStagingDirectory) != ''">$(Build_ArtifactStagingDirectory)</PackageOutputPath> | ||
<IncludeSymbols>true</IncludeSymbols> | ||
<SymbolPackageFormat>snupkg</SymbolPackageFormat> | ||
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression> | ||
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want this? .NET seems to use false
. https://github.com/dotnet/runtime/blob/8bb7b2ac092a6580b1cc247bc705e737c2b0260d/Directory.Build.props#L355
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that too. Not sure why we have true
there TBH. I'll bring up on the next SIG for discussion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a blocker for this PR.
Relates to #5187
Changes
Include license files in packages.
Rename
LICENSE
->LICENSE.TXT
andTHIRD-PARTY-NOTICES
->THIRD-PARTY-NOTICES.TXT
. Without a file extension when packaged they end up going into their own folders. With a file extension they end up in the root:Details
For this work I am using dotnet/runtime as guide:
Merge requirement checklist