Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Include license files in packages #5192

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Dec 19, 2023

Relates to #5187

Changes

  • Include license files in packages.

  • Rename LICENSE -> LICENSE.TXT and THIRD-PARTY-NOTICES -> THIRD-PARTY-NOTICES.TXT. Without a file extension when packaged they end up going into their own folders. With a file extension they end up in the root:

    image

Details

For this work I am using dotnet/runtime as guide:

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team December 19, 2023 19:33
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d8ef70) 83.43% compared to head (b839628) 83.49%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5192      +/-   ##
==========================================
+ Coverage   83.43%   83.49%   +0.05%     
==========================================
  Files         297      297              
  Lines       12396    12395       -1     
==========================================
+ Hits        10343    10349       +6     
+ Misses       2053     2046       -7     
Flag Coverage Δ
unittests 83.49% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

build/Common.prod.props Outdated Show resolved Hide resolved
<PackageOutputPath Condition="$(Build_ArtifactStagingDirectory) != ''">$(Build_ArtifactStagingDirectory)</PackageOutputPath>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<PackageLicenseExpression>Apache-2.0</PackageLicenseExpression>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that too. Not sure why we have true there TBH. I'll bring up on the next SIG for discussion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR.

LICENSE.txt Outdated Show resolved Hide resolved
OpenTelemetry.sln Outdated Show resolved Hide resolved
OpenTelemetry.sln Outdated Show resolved Hide resolved
@utpilla utpilla merged commit 14ee5c4 into open-telemetry:main Dec 19, 2023
38 checks passed
@CodeBlanch CodeBlanch deleted the package-license-files branch December 20, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants