Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpClient] Fix errorType statusCode #5039

Merged

Conversation

vishweshbankwar
Copy link
Member

Follow up #5034 (comment)

@vishweshbankwar vishweshbankwar marked this pull request as ready for review November 9, 2023 22:33
@vishweshbankwar vishweshbankwar requested a review from a team November 9, 2023 22:33
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5039 (e5ce2c1) into main (94ede6e) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5039      +/-   ##
==========================================
- Coverage   83.54%   83.34%   -0.20%     
==========================================
  Files         296      296              
  Lines       12467    12467              
==========================================
- Hits        10415    10391      -24     
- Misses       2052     2076      +24     
Flag Coverage Δ
unittests 83.34% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...tp/Implementation/HttpHandlerDiagnosticListener.cs 73.50% <100.00%> (ø)
...ementation/HttpHandlerMetricsDiagnosticListener.cs 90.14% <100.00%> (ø)

... and 5 files with indirect coverage changes

@utpilla utpilla merged commit b7bc57b into open-telemetry:main Nov 9, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants