Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #5033

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Fix broken links #5033

merged 3 commits into from
Nov 9, 2023

Conversation

danelson
Copy link
Contributor

@danelson danelson commented Nov 9, 2023

Fixes #5030

Changes

Updated broken links that had a base uri of https://github.com/open-telemetry/opentelemetry-specification

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@danelson danelson requested a review from a team November 9, 2023 13:48
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #5033 (e36f7b8) into main (0a989a9) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5033      +/-   ##
==========================================
+ Coverage   83.36%   83.52%   +0.15%     
==========================================
  Files         296      296              
  Lines       12440    12440              
==========================================
+ Hits        10371    10390      +19     
+ Misses       2069     2050      -19     
Flag Coverage Δ
unittests 83.52% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/OpenTelemetry.Api/Trace/SpanAttributes.cs 100.00% <ø> (ø)
...ometheus.HttpListener/Internal/PrometheusMetric.cs 71.75% <ø> (ø)
...ion.AspNetCore/AspNetCoreInstrumentationOptions.cs 100.00% <ø> (ø)
...tation.AspNetCore/Implementation/HttpInListener.cs 91.87% <ø> (ø)
...try.Instrumentation.GrpcNetClient/GrpcTagHelper.cs 95.65% <ø> (ø)
...mentation.Http/HttpClientInstrumentationOptions.cs 100.00% <ø> (ø)
...ation.SqlClient/SqlClientInstrumentationOptions.cs 98.87% <ø> (ø)
src/OpenTelemetry/Resources/ResourceBuilder.cs 91.93% <ø> (ø)
...enTelemetry/Resources/ResourceBuilderExtensions.cs 100.00% <ø> (ø)
src/Shared/SpanHelper.cs 100.00% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Member

@vishweshbankwar vishweshbankwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danelson!

Co-authored-by: Vishwesh Bankwar <[email protected]>
@danelson
Copy link
Contributor Author

danelson commented Nov 9, 2023

@vishweshbankwar no problem. Thanks for your review and good idea to use the domain specific links where applicable. I added your changes.

@utpilla utpilla merged commit 00750dd into open-telemetry:main Nov 9, 2023
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken links due to semantic conventions move
3 participants