[Documentation] Update docs for selecting specific tags of a metric instrument #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit `customizing-the-sdk` page to give more detail about the outcome of tag dropping
|
Sorting out CLA with my employer ASAP 😄 |
utpilla
approved these changes
Nov 2, 2023
|
@jwreford99 Thanks for sending the PR! I really appreciate the due diligence you exercised to update the documentation! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first attempted contribution to this repo, most of the guidelines seem to focus around code changes, when I just wanted to add a little extra detail to some documentation! If the format I've done this in is egregiously wrong apologies, just trying to be useful as this confused me for a while.
Changes
The documentation for selecting specific tags on instruments is clear about the tags that are dropped, but isn't super clear on the aggregation side (i.e. what do the resulting values look like when you've dropped the tags).
I ended up going all the way back to #2442 to be 100% confident that it is doing what I was expecting.
Therefore, I figured it would be worth bringing that brief summary to the docs as well. I've tried to be concise and clear, but v happy for feedback if I've done it horribly wrong!
Merge requirement checklist