Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarification on RecordException #4861

Closed
wants to merge 2 commits into from
Closed

Clarification on RecordException #4861

wants to merge 2 commits into from

Conversation

pegasas
Copy link
Contributor

@pegasas pegasas commented Sep 17, 2023 •
edited
Loading

Fixes open-telemetry/opentelemetry-dotnet-contrib#1749

Changes

Add Clarification on RecordException
see open-telemetry/opentelemetry-dotnet-contrib#1749

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@pegasas pegasas requested a review from a team September 17, 2023 03:54
reyang
reyang requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which part is unclear, and why would this change make it clear?

@pegasas
Copy link
Contributor Author

pegasas commented Sep 18, 2023

Which part is unclear, and why would this change make it clear?

I think maybe we should clarify unhandled exception in a more specific way?

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 26, 2023
@pegasas pegasas requested a review from reyang September 26, 2023 12:50
@github-actions github-actions bot removed the Stale Issues and pull requests which have been flagged for closing due to inactivity label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day.

@github-actions github-actions bot added the Stale Issues and pull requests which have been flagged for closing due to inactivity label Oct 4, 2023
@vishweshbankwar
Copy link
Member

@pegasas Thanks for raising this!. I don't think this is resolving the concern raised in the issue. open-telemetry/opentelemetry-dotnet-contrib#1749. Exceptions handled in the middleware are not unhandled. The doc already calls out it only records unhandled exceptions. I am closing this PR for now, Please comment on the issue as to what specifically is not clear in Readme.

@pegasas pegasas deleted the record-exception branch October 13, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang Awaiting requested review from reyang

Assignees
No one assigned
Labels
Stale Issues and pull requests which have been flagged for closing due to inactivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RecordException doesn't work with ExceptionHandler middleware
3 participants
@pegasas @vishweshbankwar @reyang