update Semantic Conventions: grpc attributes in aspnetcore #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4660 +/- ##
==========================================
+ Coverage 85.01% 85.02% +0.01%
==========================================
Files 314 314
Lines 12723 12725 +2
==========================================
+ Hits 10817 10820 +3
+ Misses 1906 1905 -1
|
This comment was marked as resolved.
This comment was marked as resolved.
vishweshbankwar
approved these changes
Jul 15, 2023
utpilla
reviewed
Jul 17, 2023
| // https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/http/http-spans.md | ||
| // https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/database/database-spans.md | ||
| // https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/rpc/rpc-spans.md | ||
| public const string AttributeClientAddress = "client.address"; |
There was a problem hiding this comment.
It would be good to add a comment saying this replaces net.peer.ip in specific cases.
utpilla
reviewed
Jul 17, 2023
| public void GrpcAspNetCoreInstrumentationAddsCorrectAttributes_New(bool? enableGrpcAspNetCoreSupport) | ||
| { | ||
| var configuration = new ConfigurationBuilder() | ||
| .AddInMemoryCollection(new Dictionary<string, string> { [SemanticConventionOptInKeyName] = "http" }) |
There was a problem hiding this comment.
Need not be done in this PR but the tests shouldn't be using the const string variable SemanticConventionOptInKeyName directly from src file. Our tests. would not complain about it when someone accidentally changes the value for it in the src file.
utpilla
reviewed
Jul 17, 2023
utpilla
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design discussion issue #4484
Changes
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes