Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor perf improvement aspnetcore #4551

Merged

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jun 6, 2023

Towards #4376
Design discussion issue #

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #4551 (acffab1) into main (e74e0ed) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4551   +/-   ##
=======================================
  Coverage   85.42%   85.42%           
=======================================
  Files         320      320           
  Lines       12640    12641    +1     
=======================================
+ Hits        10798    10799    +1     
  Misses       1842     1842           
Impacted Files Coverage Δ
...tation.AspNetCore/Implementation/HttpInListener.cs 90.24% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review June 6, 2023 20:36
@vishweshbankwar vishweshbankwar requested a review from a team June 6, 2023 20:36
@@ -76,7 +75,7 @@

Baseline = 2.45 KB
With Traces and Metrics = Baseline + With Traces + (With Metrics - (Activity creation + `Acitivity.Stop()`)) (they use the same activity)
= 2.45 + (1162 + 64) / 1024 = 2.45 + 1.2 = 3.55 KB (~3.56 KB)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous version seems to have the wrong math 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was a typo but it does match what's in the Allocated column in the table (3.66 KB)

= 2.45 + (1162 + 64) / 1024 = 2.45 + 1.2 = 3.65 KB (~3.66 KB)

@utpilla utpilla merged commit 6e73bb9 into open-telemetry:main Jun 6, 2023
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants