-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor perf improvement aspnetcore #4551
Minor perf improvement aspnetcore #4551
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4551 +/- ##
=======================================
Coverage 85.42% 85.42%
=======================================
Files 320 320
Lines 12640 12641 +1
=======================================
+ Hits 10798 10799 +1
Misses 1842 1842
|
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
@@ -76,7 +75,7 @@ | |||
|
|||
Baseline = 2.45 KB | |||
With Traces and Metrics = Baseline + With Traces + (With Metrics - (Activity creation + `Acitivity.Stop()`)) (they use the same activity) | |||
= 2.45 + (1162 + 64) / 1024 = 2.45 + 1.2 = 3.55 KB (~3.56 KB) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version seems to have the wrong math 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that was a typo but it does match what's in the Allocated
column in the table (3.66 KB)
= 2.45 + (1162 + 64) / 1024 = 2.45 + 1.2 = 3.65 KB (~3.66 KB)
Towards #4376
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes