Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NETCOREAPP3_0_OR_GREATER to NET6_0_OR_GREATER #4367

Merged

Conversation

alanwest
Copy link
Member

@alanwest alanwest commented Apr 5, 2023

We no longer have anything that targets netcoreapp3.x or net5

@alanwest alanwest requested a review from a team April 5, 2023 19:42
@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4367 (0d73578) into main (dac0cf1) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4367      +/-   ##
==========================================
- Coverage   84.74%   84.71%   -0.04%     
==========================================
  Files         300      300              
  Lines       12003    12003              
==========================================
- Hits        10172    10168       -4     
- Misses       1831     1835       +4     
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Internal/Guard.cs 100.00% <ø> (ø)
src/OpenTelemetry/Internal/MathHelper.cs 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

@alanwest alanwest merged commit 0004895 into open-telemetry:main Apr 6, 2023
@alanwest alanwest deleted the alanwest/adjust-preproc-directives branch April 6, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants