Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min/max snapshot for explicit bounds histogram #4306

Merged
merged 3 commits into from
Mar 16, 2023

Conversation

alanwest
Copy link
Member

The min and max values were not captured in the MetricSnapshot for the InMemory exporter.

@alanwest alanwest requested a review from a team March 15, 2023 20:13
@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Merging #4306 (caedbcb) into main (3d6656f) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4306      +/-   ##
==========================================
- Coverage   84.55%   84.53%   -0.03%     
==========================================
  Files         298      298              
  Lines       11893    11895       +2     
==========================================
- Hits        10056    10055       -1     
- Misses       1837     1840       +3     
Impacted Files Coverage Δ
src/OpenTelemetry/Metrics/HistogramBuckets.cs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@utpilla utpilla merged commit d924663 into open-telemetry:main Mar 16, 2023
@alanwest alanwest deleted the alanwest/in-memory-min-max branch March 21, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants