Fix: Logs could be exported via ConsoleExporter after LoggerFactory is disposed #1848

src/OpenTelemetry.Exporter.Console/.publicApi/net462/PublicAPI.Unshipped.txt

@@ -0,0 +1 @@
+override OpenTelemetry.Exporter.ConsoleLogRecordExporter.Dispose(bool disposing) -> void

src/OpenTelemetry.Exporter.Console/.publicApi/netstandard2.0/PublicAPI.Unshipped.txt

@@ -0,0 +1 @@
+override OpenTelemetry.Exporter.ConsoleLogRecordExporter.Dispose(bool disposing) -> void

src/OpenTelemetry.Exporter.Console/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## Unreleased
 
+* Changed error handling, `ConsoleExporter` will output error messages,
+  tell user where dispose happened and drop the data
+  if `Export` is invoked after the exporter is disposed.
+  ([#1848](https://github.com/open-telemetry/opentelemetry-dotnet/issues/1848))
+
 ## 1.4.0-alpha.2
 
 Released 2022-Aug-18

src/OpenTelemetry.Exporter.Console/ConsoleLogRecordExporter.cs

@@ -14,6 +14,7 @@
 // limitations under the License.
 // </copyright>
 
+using System;
 using System.Collections.Generic;
 using OpenTelemetry.Logs;
 using OpenTelemetry.Resources;
@@ -23,6 +24,9 @@ namespace OpenTelemetry.Exporter
     public class ConsoleLogRecordExporter : ConsoleExporter<LogRecord>
     {
         private const int RightPaddingLength = 35;
+        private bool disposed;
+        private string disposedStackTrace;
+        private bool isDisposeMessageSent;
 
         public ConsoleLogRecordExporter(ConsoleExporterOptions options)
             : base(options)
@@ -31,6 +35,20 @@ public ConsoleLogRecordExporter(ConsoleExporterOptions options)
 
         public override ExportResult Export(in Batch<LogRecord> batch)
         {
+            if (this.disposed)
+            {
+                if (!this.isDisposeMessageSent)
+                {
+                    this.isDisposeMessageSent = true;
+                    this.WriteLine("The console exporter is still being invoked after it has been disposed. This could be the result of invalid lifecycle management of the OpenTelemetry .NET SDK.");
+                    this.WriteLine(Environment.StackTrace);
+                    this.WriteLine(Environment.NewLine + "Dispose was called on the following stack trace:");
+                    this.WriteLine(this.disposedStackTrace);
+                }
+
+                return ExportResult.Failure;
+            }
+
             foreach (var logRecord in batch)
             {
                 this.WriteLine($"{"LogRecord.Timestamp:",-RightPaddingLength}{logRecord.Timestamp:yyyy-MM-ddTHH:mm:ss.fffffffZ}");
@@ -129,5 +147,16 @@ void ProcessScope(LogRecordScope scope, ConsoleLogRecordExporter exporter)
 
             return ExportResult.Success;
         }
+
+        protected override void Dispose(bool disposing)
+        {
+            if (!this.disposed)
+            {
+                this.disposed = true;
+                this.disposedStackTrace = Environment.StackTrace;
+            }
+
+            base.Dispose(disposing);
+        }
     }
 }