Fix EventSource for B3Propagator #3336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
reviewed
Jun 3, 2022
| /// This is used for internal logging of this library. | ||
| /// </summary> | ||
| [EventSource(Name = "OpenTelemetry.Extensions.Propagators")] | ||
| internal class OpenTelemetryPropagatorsEventSource : EventSource |
CodeBlanch
reviewed
Jun 3, 2022
| [EventSource(Name = "OpenTelemetry.Extensions.Propagators")] | ||
| internal class OpenTelemetryPropagatorsEventSource : EventSource | ||
| { | ||
| public static OpenTelemetryPropagatorsEventSource Log = new(); |
There was a problem hiding this comment.
nit:
public static readonly OpenTelemetryPropagatorsEventSource Log = new();
or
public static OpenTelemetryPropagatorsEventSource Log { get; } = new();
|
Both the nits should be applied across entire set of EventSource classes. Would make it a follow up PR. |
alanwest
reviewed
Jun 3, 2022
src/OpenTelemetry.Extensions.Propagators/OpenTelemetryPropagatorsEventSource.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #3336 +/- ##
=======================================
Coverage 85.44% 85.44%
=======================================
Files 269 270 +1
Lines 9552 9560 +8
=======================================
+ Hits 8162 8169 +7
- Misses 1390 1391 +1
|
alanwest
approved these changes
Jun 3, 2022
…orsEventSource.cs Co-authored-by: Alan West <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Own eventsource.
Also moved the public api files to unshipped, as the stable has not been released yet