Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleMetricExporter to export all resource attributes #3334

Merged

Conversation

cijothomas
Copy link
Member

MetricExporter was only printing the servicename attribute. This fixes it to print all resource attributes, just like log and activity exporter.

@cijothomas cijothomas requested a review from a team June 3, 2022 15:43
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #3334 (4597311) into main (fa21e1e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3334   +/-   ##
=======================================
  Coverage   85.45%   85.45%           
=======================================
  Files         269      269           
  Lines        9552     9552           
=======================================
  Hits         8163     8163           
  Misses       1389     1389           
Impacted Files Coverage Δ
...ZPages/Implementation/ZPagesExporterEventSource.cs 56.25% <0.00%> (-6.25%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 6493cdd into open-telemetry:main Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants