Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagation in case of remote parent #3310

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented May 27, 2022

Fixes #.

Changes

Please provide a brief description of the changes here.

Adding unit test for scenario described in #3315. Will create a follow-up PR with TraceProviderSDK changes if the proposal looks ok.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar marked this pull request as ready for review May 27, 2022 18:35
@vishweshbankwar vishweshbankwar requested a review from a team May 27, 2022 18:35
@codecov
Copy link

codecov bot commented May 27, 2022

Codecov Report

Merging #3310 (ff4c58a) into main (3b0e759) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3310      +/-   ##
==========================================
- Coverage   85.42%   85.41%   -0.02%     
==========================================
  Files         269      269              
  Lines        9552     9552              
==========================================
- Hits         8160     8159       -1     
- Misses       1392     1393       +1     
Impacted Files Coverage Δ
...heus/Implementation/PrometheusCollectionManager.cs 79.74% <0.00%> (-2.54%) ⬇️
...Telemetry/Internal/SelfDiagnosticsEventListener.cs 96.87% <0.00%> (-0.79%) ⬇️
src/OpenTelemetry/BatchExportProcessor.cs 83.80% <0.00%> (+1.90%) ⬆️

@cijothomas cijothomas merged commit 0b09346 into open-telemetry:main Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants