-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tracing): deprecate use of B3 propagator class from API package - use Extensions.Propagators package instead #3289
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3289 +/- ##
==========================================
+ Coverage 85.41% 85.42% +0.01%
==========================================
Files 269 269
Lines 9552 9552
==========================================
+ Hits 8159 8160 +1
+ Misses 1393 1392 -1
|
I am not sure if I am missing something, but methods have been annotated with Depending on the progress in #3293, it will need to be rebased.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested improving obsolete message. This is 1st time we are Obsolete ing something from this repo, so need to make sure the migration is as smooth as possible.
Agree. I have slightly improved the wording of the deprecation message, plus added a comment to the class. |
Co-authored-by: Cijo Thomas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In preparation of #3259 and continuation of the previous 2 PRs, in this pull request, we deprecate use of B3 in API package.
Instead of using OTEL.API nuget package, use now OTel.Extensions.Propagators nuget package for B3 tracing format
Changes
CHANGELOG.md
updated for non-trivial changes