Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tracing): deprecate use of B3 propagator class from API package - use Extensions.Propagators package instead #3289

Merged
merged 13 commits into from
May 31, 2022

Conversation

dmpe
Copy link
Contributor

@dmpe dmpe commented May 18, 2022

In preparation of #3259 and continuation of the previous 2 PRs, in this pull request, we deprecate use of B3 in API package.

Instead of using OTEL.API nuget package, use now OTel.Extensions.Propagators nuget package for B3 tracing format

Changes

@dmpe dmpe requested a review from a team May 18, 2022 20:04
@dmpe dmpe marked this pull request as draft May 18, 2022 20:04
@dmpe dmpe changed the title deprecate use of B3 propagator from API package feat(tracing): deprecate use of B3 propagator from API package - use Extensions.Propagators package instead May 18, 2022
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #3289 (365b67a) into main (4e6d073) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3289      +/-   ##
==========================================
+ Coverage   85.41%   85.42%   +0.01%     
==========================================
  Files         269      269              
  Lines        9552     9552              
==========================================
+ Hits         8159     8160       +1     
+ Misses       1393     1392       -1     
Impacted Files Coverage Δ
...nTelemetry.Api/Context/Propagation/B3Propagator.cs 85.86% <ø> (ø)
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 97.14% <0.00%> (-2.86%) ⬇️
...metryProtocol/Implementation/ActivityExtensions.cs 95.60% <0.00%> (+1.09%) ⬆️

@dmpe dmpe marked this pull request as ready for review May 21, 2022 11:37
@dmpe
Copy link
Contributor Author

dmpe commented May 21, 2022

I am not sure if I am missing something, but methods have been annotated with pragma and hence it would be ready for a review. Let me know if I forgot something. Thx.

Depending on the progress in #3293, it will need to be rebased....

Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested improving obsolete message. This is 1st time we are Obsolete ing something from this repo, so need to make sure the migration is as smooth as possible.

@dmpe dmpe changed the title feat(tracing): deprecate use of B3 propagator from API package - use Extensions.Propagators package instead feat(tracing): deprecate use of B3 propagator class from API package - use Extensions.Propagators package instead May 26, 2022
@dmpe
Copy link
Contributor Author

dmpe commented May 26, 2022

Suggested improving obsolete message. This is 1st time we are Obsolete ing something from this repo, so need to make sure the migration is as smooth as possible.

Agree. I have slightly improved the wording of the deprecation message, plus added a comment to the class.

Copy link
Member

@alanwest alanwest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit b045253 into open-telemetry:main May 31, 2022
@dmpe dmpe deleted the deprec_b3_api branch May 31, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants