Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove net461 from windows-ci-md, add net462 #3199

Merged
merged 2 commits into from
Apr 18, 2022
Merged

remove net461 from windows-ci-md, add net462 #3199

merged 2 commits into from
Apr 18, 2022

Conversation

TimothyMothra
Copy link
Contributor

@TimothyMothra TimothyMothra commented Apr 15, 2022

Towards #3190

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@TimothyMothra TimothyMothra requested a review from a team April 15, 2022 23:12
@TimothyMothra TimothyMothra changed the title update windows-ci-md remove net461 from windows-ci-md, add net462 Apr 15, 2022
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #3199 (86a66b0) into main (2f8bcc4) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3199      +/-   ##
==========================================
+ Coverage   85.17%   85.26%   +0.08%     
==========================================
  Files         259      259              
  Lines        9345     9345              
==========================================
+ Hits         7960     7968       +8     
+ Misses       1385     1377       -8     
Impacted Files Coverage Δ
...metryProtocol/Implementation/ActivityExtensions.cs 92.34% <0.00%> (+0.90%) ⬆️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 76.72% <0.00%> (+2.58%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 89.42% <0.00%> (+2.88%) ⬆️

@TimothyMothra
Copy link
Contributor Author

TimothyMothra commented Apr 15, 2022

@cijothomas looks like the branch rules need to be updated.
This would be in Settings > Branches > Branch protection rules.

  • remove "build-test (net461)"
    image

  • add "build-test (net462)" to be required
    image

@cijothomas cijothomas closed this Apr 16, 2022
@cijothomas cijothomas reopened this Apr 16, 2022
@cijothomas cijothomas merged commit eaa9370 into open-telemetry:main Apr 18, 2022
@TimothyMothra TimothyMothra deleted the 3190_workflows branch April 18, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants