-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part2] Support Activity Status and status description in Jaeger Exporter. #3073
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
+ Coverage 84.75% 84.77% +0.02%
==========================================
Files 259 259
Lines 9142 9170 +28
==========================================
+ Hits 7748 7774 +26
- Misses 1394 1396 +2
|
test/OpenTelemetry.Exporter.Jaeger.Tests/Implementation/JaegerActivityConversionTest.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
src/OpenTelemetry.Exporter.Jaeger/Implementation/JaegerActivityExtensions.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking to address the issue : https://github.com/open-telemetry/opentelemetry-dotnet/pull/3073/files#r833442567
Fixes parts of #2569.
Related to: #3003
Background : Please review Console.Exporter where the same logic were exercised: #3061.
Added support for Activity.Status/Description in Jaeger.Exporter.
System.Diagnostic.DiagnosticSource version 6.0.0 introduced native support for storing status/description in the Activity itself.
This PR modified the exporter to retrieve status from the newly added fields if it was set.
To maintain backward compatibility, the control flow would fell back to retrieve status from the activity.Tags if the native status/description were not set.
In order to support Activity Status takes precedence over Activity Tags, the logic that were in
ProcessJaegerTag
were extracted to be insideForEach()
method ofTagEnumerationState
.Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes