-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MetricReaderOptions for AddInMemoryExporter extension methods #2931
MetricReaderOptions for AddInMemoryExporter extension methods #2931
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2931 +/- ##
==========================================
- Coverage 83.87% 83.84% -0.03%
==========================================
Files 254 254
Lines 8918 8940 +22
==========================================
+ Hits 7480 7496 +16
- Misses 1438 1444 +6
|
…m:alanwest/opentelemetry-dotnet into alanwest/metric-options-inmemory-exporter
Yes +1 |
The question is self-answered in this PR itself. The tests looks much nicer :) |
As I was working through this PR I was originally feeling "🤮 I don't like it" and then I started feeling "🤔 I suppose this could work". At first I didn't think there'd ever be the need for a periodic InMemory exporter, but I guess we do have some tests that use it.
I'll let you all be the judge. Do you find it nice to have an extension method for the InMemory exporter that allows configuring the standard options for the underlying metric reader?