Drop Microsoft.AspNetCore.Http.Features from net5 & net6 #2860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2860 +/- ##
=======================================
Coverage 84.09% 84.09%
=======================================
Files 255 255
Lines 9062 9062
=======================================
Hits 7621 7621
Misses 1441 1441 |
cijothomas
reviewed
Feb 4, 2022
src/OpenTelemetry.Instrumentation.AspNetCore/OpenTelemetry.Instrumentation.AspNetCore.csproj
Outdated
Show resolved
Hide resolved
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Hello @cijothomas, can you point me in the right direction? TLDR: Version bound in the csproj - it's a fading out dependency, or to the props? |
github-actions
bot
removed
the
Stale
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
github-actions
bot
added
the
Stale
|
Ping @cijothomas |
github-actions
bot
removed
the
Stale
trejjam
force-pushed
the
feature/drop-http-features
branch
from
e006085 to
07207ea
Compare
|
Ready for re-review |
trejjam
changed the title
cijothomas
approved these changes
Mar 7, 2022
|
@trejjam could you add an entry to changelog, as this is public facing change. |
trejjam
force-pushed
the
feature/drop-http-features
branch
from
9fb6bc0 to
0c11fd0
Compare
trejjam
force-pushed
the
feature/drop-http-features
branch
from
0c11fd0 to
3e80b49
Compare
pellared
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The
Microsoft.AspNetCore.Http.Featuresis part of the net6.This PR removes the dependency on the not existing package
Microsoft.AspNetCore.Http.Features 6.0for the net6 target.