Add exporter ForceFlush #2525
Add exporter ForceFlush #2525
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2525 +/- ##
==========================================
- Coverage 80.58% 80.55% -0.03%
==========================================
Files 254 254
Lines 8507 8515 +8
==========================================
+ Hits 6855 6859 +4
- Misses 1652 1656 +4
|
Does it have to be this PR? There are many Metrics APIs not included in the API list. I can do it in a separate PR. |
| OpenTelemetry.Trace.BatchExportActivityProcessorOptions.BatchExportActivityProcessorOptions() -> void | ||
| override OpenTelemetry.BaseExportProcessor<T>.OnForceFlush(int timeoutMilliseconds) -> bool | ||
| override OpenTelemetry.BatchExportProcessor<T>.Dispose(bool disposing) -> void |
There was a problem hiding this comment.
Note that the Dispose was added by some previous PR(s).
yea we can add entire Metrics API separately. I was only asking since this PR is not related to metrics alone. |
| } | ||
| catch (Exception ex) | ||
| { | ||
| OpenTelemetrySdkEventSource.Log.SpanProcessorException(nameof(this.ForceFlush), ex); |
There was a problem hiding this comment.
This should probably be something generic rather than about spans - also this is an exporter not a processor. A lot of the events in OpenTelemetrySdkEventSource are span-centric right now... a holistic review of the usage of OpenTelemetrySdkEventSource could be useful - I can create an issue.
There was a problem hiding this comment.
Yes. this is something we need to tackle surely.
Related to this: #1529 as well
There was a problem hiding this comment.
This should probably be something generic rather than about spans - also this is an exporter not a processor. A lot of the events in
OpenTelemetrySdkEventSourceare span-centric right now... a holistic review of the usage ofOpenTelemetrySdkEventSourcecould be useful - I can create an issue.
+1, I also want to solve this problem. The current internal diagnostic logs are misleading and most of them are not actionable.
Fixes #2523.
Changes
Added
ForceFlushto exporters.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes