Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a failing unit test for InMemoryExporter<Metric> #2387

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Add a failing unit test for InMemoryExporter<Metric> #2387

merged 1 commit into from
Sep 20, 2021

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Sep 18, 2021

Changes

@utpilla utpilla requested a review from a team September 18, 2021 20:13
reyang
reyang approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov
Copy link

codecov bot commented Sep 18, 2021

Codecov Report

Merging #2387 (e72af25) into main (6ade86e) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   79.74%   79.71%   -0.03%     
==========================================
  Files         231      231              
  Lines        7459     7459              
==========================================
- Hits         5948     5946       -2     
- Misses       1511     1513       +2
Impacted Files Coverage Δ
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 73.52% <0.00%> (-5.89%) ⬇️

@cijothomas cijothomas merged commit 67e4e07 into open-telemetry:main Sep 20, 2021
@utpilla utpilla deleted the utpilla/Add-Failing-UnitTest-For-InMemoryExporter branch November 3, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cijothomas cijothomas cijothomas approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@utpilla @cijothomas @reyang