Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IDeferredTracerProviderBuilder for InMemoryExporter #2129

Conversation

utpilla
Copy link
Contributor

@utpilla utpilla commented Jul 12, 2021

Fixes the issue of #2126 for InMemoryExporter

  • CHANGELOG.md updated for non-trivial changes

@utpilla utpilla requested a review from a team July 12, 2021 19:51
@utpilla utpilla changed the title Add support for IDeferredTracerProviderBuilder Add support for IDeferredTracerProviderBuilder for InMmoryExporter Jul 12, 2021
@utpilla utpilla changed the title Add support for IDeferredTracerProviderBuilder for InMmoryExporter Add support for IDeferredTracerProviderBuilder for InMemoryExporter Jul 12, 2021
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #2129 (b3bab2d) into main (dd8cee1) will decrease coverage by 0.05%.
The diff coverage is 20.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2129      +/-   ##
==========================================
- Coverage   85.10%   85.05%   -0.06%     
==========================================
  Files         187      187              
  Lines        6098     6103       +5     
==========================================
+ Hits         5190     5191       +1     
- Misses        908      912       +4     
Impacted Files Coverage Δ
...orter.InMemory/InMemoryExporterHelperExtensions.cs 40.00% <20.00%> (-20.00%) ⬇️

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 5b06d2a into open-telemetry:main Jul 12, 2021
@utpilla utpilla deleted the utpilla/Update-InMemoryExporter-To-Support-IDeferredTracerProviderBuilder branch July 30, 2021 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants