-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParentBasedSampler should not explicitly consider Links #1851
Conversation
Just waiting for the related PR to get merged before making changes to the actual sampler. |
Codecov Report
@@ Coverage Diff @@
## main #1851 +/- ##
==========================================
- Coverage 83.77% 83.29% -0.49%
==========================================
Files 187 189 +2
Lines 5967 6123 +156
==========================================
+ Hits 4999 5100 +101
- Misses 968 1023 +55
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@mbakalov thanks! please resolve conflict and we are good to merge. |
Thanks @cijothomas - done now! |
Fixes #1846.
Changes
Previously we had functionality in
ParentBasedSampler
that would consider activity links and return RecordAndSample if one of the links was sampled. This isn't according to the spec and is removed in this PR.In a related PR we've added customization capability to
ParentBasedSampler
that can be used to examine links if needed.CHANGELOG.md
updated for non-trivial changes