Status & error flag updates to match spec #1655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1655 +/- ##
==========================================
+ Coverage 81.79% 81.80% +0.01%
==========================================
Files 245 245
Lines 6590 6605 +15
==========================================
+ Hits 5390 5403 +13
- Misses 1200 1202 +2
|
eddynaka
approved these changes
Dec 11, 2020
cijothomas
approved these changes
Dec 14, 2020
3 tasks
alanwest
added a commit
to newrelic/newrelic-telemetry-sdk-dotnet
that referenced
this pull request
Feb 2, 2021
* Update to OpenTelemetry 1.0.0-rc2 * Update changelog * Setting description on span with Ok status ignores the description. See open-telemetry/opentelemetry-dotnet#1655.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated Status & Zipkin/Jaeger exporter error flag handling based on final merged PR into spec.
TODOs:
CHANGELOG.mdupdated for non-trivial changes