Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable self diagnostics module #1573

Merged

Conversation

xiang17
Copy link
Contributor

@xiang17 xiang17 commented Nov 18, 2020

Enable the self diagnostics module as described in #1258

Changes

Initialize self diagnostics module in Sdk.cs.

Update README for config update period #1523

Rephrase remarks in the README to emphasize what/where the output file is over how the file is generated to be easier to read and more user-friendly.

@xiang17 xiang17 requested a review from a team November 18, 2020 00:16
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #1573 (00508a4) into master (c6ade39) will increase coverage by 0.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1573      +/-   ##
==========================================
+ Coverage   80.97%   81.50%   +0.53%     
==========================================
  Files         237      237              
  Lines        6448     6449       +1     
==========================================
+ Hits         5221     5256      +35     
+ Misses       1227     1193      -34     
Impacted Files Coverage Δ
src/OpenTelemetry/Sdk.cs 100.00% <100.00%> (ø)
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (+2.94%) ⬆️
...lemetry/Internal/SelfDiagnosticsConfigRefresher.cs 38.55% <0.00%> (+20.48%) ⬆️
src/OpenTelemetry/Internal/SelfDiagnostics.cs 100.00% <0.00%> (+100.00%) ⬆️

@cijothomas cijothomas merged commit 9e90fce into open-telemetry:master Nov 18, 2020
@xiang17 xiang17 deleted the xiang17/enable-self-diagnostics branch November 19, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants