Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Activity extension methods not required by spec as internal #1545

Merged
merged 9 commits into from
Nov 16, 2020

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Nov 14, 2020

Fixes #1544 .

Need to do a follow up PR to possible split Benchmarks as it has ambigous ref to same extension method. Temporarily removed the file, to be added back next PR.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team November 14, 2020 01:55
@codecov
Copy link

codecov bot commented Nov 14, 2020

Codecov Report

Merging #1545 (dfc35a7) into master (4c7d2ae) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1545      +/-   ##
==========================================
+ Coverage   81.01%   81.04%   +0.03%     
==========================================
  Files         235      236       +1     
  Lines        6414     6419       +5     
==========================================
+ Hits         5196     5202       +6     
+ Misses       1218     1217       -1     
Impacted Files Coverage Δ
...Telemetry.Api/Internal/ActivityHelperExtensions.cs 100.00% <100.00%> (ø)
src/OpenTelemetry.Api/Trace/ActivityExtensions.cs 93.75% <100.00%> (-5.35%) ⬇️
...us/Implementation/PrometheusExporterEventSource.cs 72.72% <0.00%> (+9.09%) ⬆️

@cijothomas
Copy link
Member Author

@CodeBlanch @reyang Please review. This will have cause a lot of merge conflicts with other PRs if left for a long time :D

Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cijothomas cijothomas merged commit 51806b7 into master Nov 16, 2020
@cijothomas cijothomas deleted the cijothomas/activityextensionsasinternal branch November 16, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove public extension methods on Activity not required for functionality/spec
4 participants