-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark Activity extension methods not required by spec as internal #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlanch
reviewed
Nov 14, 2020
CodeBlanch
reviewed
Nov 14, 2020
…ting the project into multiple projects
Codecov Report
@@ Coverage Diff @@
## master #1545 +/- ##
==========================================
+ Coverage 81.01% 81.04% +0.03%
==========================================
Files 235 236 +1
Lines 6414 6419 +5
==========================================
+ Hits 5196 5202 +6
+ Misses 1218 1217 -1
|
@CodeBlanch @reyang Please review. This will have cause a lot of merge conflicts with other PRs if left for a long time :D |
reyang
reviewed
Nov 14, 2020
Co-authored-by: Reiley Yang <[email protected]>
eddynaka
approved these changes
Nov 14, 2020
CodeBlanch
approved these changes
Nov 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1544 .
Need to do a follow up PR to possible split Benchmarks as it has ambigous ref to same extension method. Temporarily removed the file, to be added back next PR.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes