Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed IsOk property from Status and fixed StatusCode enum values #1414

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Removed IsOk property from Status and fixed StatusCode enum values #1414

merged 3 commits into from
Oct 28, 2020

Conversation

eddynaka
Copy link
Contributor

@eddynaka eddynaka commented Oct 28, 2020 •
edited
Loading

Fixes #1398

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka changed the title Removing IsOk property Removed IsOk property from Status and fixed StatusCode enum values Oct 28, 2020
@eddynaka eddynaka marked this pull request as ready for review October 28, 2020 19:06
@eddynaka eddynaka requested a review from a team October 28, 2020 19:06
@eddynaka eddynaka self-assigned this Oct 28, 2020
CodeBlanch
CodeBlanch approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 28, 2020

Codecov Report

Merging #1414 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
- Coverage   81.28%   81.27%   -0.01%     
==========================================
  Files         227      227              
  Lines        6112     6111       -1     
==========================================
- Hits         4968     4967       -1     
  Misses       1144     1144
Impacted Files Coverage Δ
src/OpenTelemetry.Api/Trace/Status.cs 96.55% <ø> (-0.12%) ⬇️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <0.00%> (+2.85%) ⬆️

@cijothomas cijothomas merged commit 9cd31cf into open-telemetry:master Oct 28, 2020
@eddynaka eddynaka deleted the feature/removing-isok branch October 28, 2020 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanwest alanwest alanwest left review comments

@CodeBlanch CodeBlanch CodeBlanch approved these changes

@cijothomas cijothomas cijothomas approved these changes

Assignees

@eddynaka eddynaka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Status.IsOkay helper method fixes
4 participants
@eddynaka @alanwest @cijothomas @CodeBlanch