Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ActivityEvent.EnumerateTags & ActivityLink.EnumerateTags extensions #1320

Merged
Prev Previous commit
Next Next commit
Merging latest from master.
CodeBlanch committed Oct 7, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 91264a2bb6a63faf106c6d64f1962009a593a38d
3 changes: 3 additions & 0 deletions src/OpenTelemetry.Api/Trace/ActivityExtensions.cs
Original file line number Diff line number Diff line change
@@ -102,6 +102,7 @@ public static object GetTagValue(this Activity activity, string tagName)
/// <param name="activity">Activity instance.</param>
/// <param name="tagEnumerator">Tag enumerator.</param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "ActivityProcessor is hot path")]
public static void EnumerateTags<T>(this Activity activity, ref T tagEnumerator)
where T : struct, IActivityEnumerator<KeyValuePair<string, object>>
{
@@ -133,6 +134,7 @@ public static void EnumerateLinks<T>(this Activity activity, ref T linkEnumerato
/// <param name="activityLink">ActivityLink instance.</param>
/// <param name="tagEnumerator">Tag enumerator.</param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "ActivityProcessor is hot path")]
public static void EnumerateTags<T>(this ActivityLink activityLink, ref T tagEnumerator)
where T : struct, IActivityEnumerator<KeyValuePair<string, object>>
{
@@ -162,6 +164,7 @@ public static void EnumerateEvents<T>(this Activity activity, ref T eventEnumera
/// <param name="activityEvent">ActivityEvent instance.</param>
/// <param name="tagEnumerator">Tag enumerator.</param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
[System.Diagnostics.CodeAnalysis.SuppressMessage("Design", "CA1062:Validate arguments of public methods", Justification = "ActivityProcessor is hot path")]
public static void EnumerateTags<T>(this ActivityEvent activityEvent, ref T tagEnumerator)
where T : struct, IActivityEnumerator<KeyValuePair<string, object>>
{
You are viewing a condensed version of this merge commit. You can view the full changes here.